fix(schema-compiler): Fix pre-agg matching for 'rollupJoin' / 'rollupLambda' pre-aggregations #10017
+931
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
from
8e58477 to
094dd8b
Compare
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
from
094dd8b to
76fe519
Compare
github-actions
bot
added
the
javascript
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10017 +/- ##
==========================================
+ Coverage 48.77% 48.89% +0.11%
==========================================
Files 196 196
Lines 15859 15917 +58
Branches 3108 3110 +2
==========================================
+ Hits 7736 7783 +47
- Misses 7729 7743 +14
+ Partials 394 391 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
3 times, most recently
from
48b1d14 to
a90cdee
Compare
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
from
a90cdee to
0304b5c
Compare
paveltiunov
approved these changes
Oct 22, 2025
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
3 times, most recently
from
3237841 to
9ac45c8
Compare
…Lambda' pre-aggregations
KSDaemon
force-pushed
the
fix/rollup-join-match
branch
from
9ac45c8 to
d2332b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect pre-agg matching in case of 'rollupJoin' / 'rollupLambda' pre-aggs
Check List